JPDev@programming.dev to Programmer Humor@programming.dev · 1 年前Review Pleaseprogramming.devimagemessage-square110fedilinkarrow-up1992arrow-down117
arrow-up1975arrow-down1imageReview Pleaseprogramming.devJPDev@programming.dev to Programmer Humor@programming.dev · 1 年前message-square110fedilink
minus-squareswordsmanluke@programming.devlinkfedilinkarrow-up14·1 年前Net removal of 1500 LoC… I’m gonna make you break this up into multiple PRs before reviewing, but honestly, if your refactoring reduced the surface area by 20% I’m a happy man.
minus-squareGraz@feddit.delinkfedilinkarrow-up1·1 年前it’s just removed unit tests that didn’t work any more…
Net removal of 1500 LoC…
I’m gonna make you break this up into multiple PRs before reviewing, but honestly, if your refactoring reduced the surface area by 20% I’m a happy man.
it’s just removed unit tests that didn’t work any more…
😱